Skip to content

[stdlib] Move DoubleWidth into its own file #10131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

natecook1000
Copy link
Member

Integers.swift.gyb is long enough as it is.

@natecook1000 natecook1000 requested a review from moiseev June 6, 2017 00:36
@natecook1000
Copy link
Member Author

@swift-ci Please smoke test

@moiseev
Copy link
Contributor

moiseev commented Jun 6, 2017

The error is:

stdout>>> check failed at /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/stdlib/Integers.swift.gyb, line 634
stdout>>> expected: true
stdout>>> check failed at /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/stdlib/Integers.swift.gyb, line 637
stdout>>> expected: true
stdout>>> check failed at /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/stdlib/Integers.swift.gyb, line 640
stdout>>> expected: true
[     FAIL ] DoubleWidth.Literals
[ RUN      ] DoubleWidth.Arithmetic/unsigned
stdout>>> check failed at /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/stdlib/Integers.swift.gyb, line 652
stdout>>> expected: (0, 88) (of type Swift.DoubleWidth<Swift.UInt8>)
stdout>>>   = [+]58
stdout>>> actual: (27, 88) (of type Swift.DoubleWidth<Swift.UInt8>)
stdout>>>   = [+]1B58
stdout>>> 
stdout>>> check failed at /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/stdlib/Integers.swift.gyb, line 653
stdout>>> expected: (0, 97) (of type Swift.DoubleWidth<Swift.UInt8>)
stdout>>>   = [+]61
stdout>>> actual: (30, 97) (of type Swift.DoubleWidth<Swift.UInt8>)
stdout>>>   = [+]1E61
stdout>>> 
[     FAIL ] DoubleWidth.Arithmetic/unsigned
[ RUN      ] DoubleWidth.Arithmetic/signed
stdout>>> check failed at /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/stdlib/Integers.swift.gyb, line 675
stdout>>> expected: (0, 88) (of type Swift.DoubleWidth<Swift.Int8>)
stdout>>>   = [+]58
stdout>>> actual: (27, 88) (of type Swift.DoubleWidth<Swift.Int8>)
stdout>>>   = [+]1B58
stdout>>> 
stdout>>> check failed at /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/stdlib/Integers.swift.gyb, line 676
stdout>>> expected: (0, 159) (of type Swift.DoubleWidth<Swift.Int8>)
stdout>>>   = [+]9F
stdout>>> actual: (-31, 159) (of type Swift.DoubleWidth<Swift.Int8>)
stdout>>>   = [-]E19F
stdout>>> 
stdout>>> check failed at /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/stdlib/Integers.swift.gyb, line 677
stdout>>> expected: (0, 168) (of type Swift.DoubleWidth<Swift.Int8>)
stdout>>>   = [+]A8
stdout>>> actual: (-28, 168) (of type Swift.DoubleWidth<Swift.Int8>)
stdout>>>   = [-]E4A8
stdout>>> 
stdout>>> check failed at /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/stdlib/Integers.swift.gyb, line 678
stdout>>> expected: (0, 97) (of type Swift.DoubleWidth<Swift.Int8>)
stdout>>>   = [+]61
stdout>>> actual: (30, 97) (of type Swift.DoubleWidth<Swift.Int8>)
stdout>>>   = [+]1E61
stdout>>> 
[     FAIL ] DoubleWidth.Arithmetic/signed

@natecook1000
Copy link
Member Author

@swift-ci Please smoke test

@natecook1000
Copy link
Member Author

@moiseev Gyb/brain fail

@natecook1000
Copy link
Member Author

Also, we should figure out how to make sure the integers tests run on a big-endian platform.

@dabrahams
Copy link
Contributor

dabrahams commented Jun 6, 2017 via email

@dabrahams dabrahams merged commit 4bfa2bf into swiftlang:master Jun 6, 2017
@natecook1000 natecook1000 deleted the nc-dw-sep branch June 8, 2017 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants