[sil] Change two SILInstruction::removeFromParent => SILInstruction::eraseFromParent. #10145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asicBlock>. addNodeToList only needs to be implemented to override the default callback behavior of ilist_trait_defaults<SILBasicBlock>. This implmentation in ilist_traits<SILBasicBlock> is exactly the same as the default callback so is unnecessary.
…eraseFromParent. removeFromParent should only be used when one is moving a SILInstruction from one block to another or in preparation for deleting an instruction. In this case, we are removing these two SILInstructions from their parent block and leaking the instruction. The right thing to do is to use eraseFromParent. <rdar://problem/31276565>
|
@swift-ci smoke test |
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sil] Change two SILInstruction::removeFromParent => SILInstruction::eraseFromParent.
removeFromParent should only be used when one is moving a SILInstruction from
one block to another or in preparation for deleting an instruction. In this
case, we are removing these two SILInstructions from their parent block and
leaking the instruction. The right thing to do is to use eraseFromParent.
rdar://problem/31276565