Skip to content

[SR-4978] Fix compiler crash for malformed ASTs #10199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jun 13, 2017
Merged

[SR-4978] Fix compiler crash for malformed ASTs #10199

merged 1 commit into from Jun 13, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2017

Resolves SR-4978.

@ghost
Copy link
Author

ghost commented Jun 12, 2017

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor

Do you mind adding a test case?

@slavapestov slavapestov requested a review from jrose-apple June 12, 2017 04:47
@ghost
Copy link
Author

ghost commented Jun 12, 2017

New to this but I will try to have a go at it

@jrose-apple
Copy link
Contributor

Thanks, Nate! I think for the test you'd just want to have a file with a bunch of those declarations at the top level (init, deinit, case etc.). You can add them to tests/NameBinding/reference-dependencies-errors.swift, then check that the test fails before your change and succeeds after it. (There's information on how to run a single test in docs/Testing.rst.)

@ghost
Copy link
Author

ghost commented Jun 12, 2017

Thank you Jordan for the direction. Tested locally.

@CodaFi
Copy link
Contributor

CodaFi commented Jun 12, 2017

@swift-ci please smoke test

@slavapestov slavapestov merged commit ec45c61 into swiftlang:master Jun 13, 2017
@ghost ghost deleted the SR-4978 branch June 13, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants