[PrintAsObjC] Silence -Wnullability for the generated declarations. #10247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Swift 3 and Swift 4 might have different views of an Objective-C API's nullability, we can end up with incompatible overrides, including with inherited initializers. This is unfortunate but also realistic; the Swift 3 code is /not/ set up to handle the new nullability used by Swift 4 and Objective-C. Just silence the warning. (It would be nice to not print inherited initializers at all, but that would mean making sure there are no convenience initializers we have to print as well. Otherwise the class would get mistaken for one without explicit designated initializers.) rdar://problem/32571301
|
@swift-ci Please smoke test |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 14, 2017
…wiftlang#10247) Since Swift 3 and Swift 4 might have different views of an Objective-C API's nullability, we can end up with incompatible overrides, including with inherited initializers. This is unfortunate but also realistic; the Swift 3 code is /not/ set up to handle the new nullability used by Swift 4 and Objective-C. Just silence the warning. (It would be nice to not print inherited initializers at all, but that would mean making sure there are no convenience initializers we have to print as well. Otherwise the class would get mistaken for one without explicit designated initializers.) rdar://problem/32571301
|
LGTM, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Swift 3 and Swift 4 might have different views of an Objective-C API's nullability, we can end up with incompatible overrides, including with inherited initializers. This is unfortunate but also realistic; the Swift 3 code is not set up to handle the new nullability used by Swift 4 and Objective-C. Just silence the warning.
(It would be nice to not print inherited initializers at all, but that would mean making sure there are no convenience initializers we have to print as well. Otherwise the class would get mistaken for one without explicit designated initializers.)
rdar://problem/32571301