[Shepherd] Do stricter checking of -D command line arguments #10248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the condition "name" is a proper identifier, and generate an error when assigning specific values in -D conditions. Fixes SR-2404.
|
@swift-ci please smoke test |
jrose-apple
reviewed
Jun 14, 2017
test/Driver/options-repl.swift
Outdated
| @@ -16,15 +16,15 @@ | |||
|
|
|||
|
|
|||
| // RUN: %swift_driver -lldb-repl -### | %FileCheck -check-prefix=LLDB %s | |||
| // RUN: %swift_driver -lldb-repl -DA,B,C -DD -L /path/to/libraries -L /path/to/more/libraries -F /path/to/frameworks -lsomelib -framework SomeFramework -sdk / -I "this folder" -module-name Test -target %target-triple -### | %FileCheck -check-prefix=LLDB-OPTS %s | |||
| // RUN: %swift_driver -lldb-repl -DD -L /path/to/libraries -L /path/to/more/libraries -F /path/to/frameworks -lsomelib -framework SomeFramework -sdk / -I "this folder" -module-name Test -target %target-triple -### | %FileCheck -check-prefix=LLDB-OPTS %s | |||
There was a problem hiding this comment.
Please do still include multiple -D flags. It's not critical but the test was confirming that they get passed in the same order.
CodaFi
force-pushed
the
conditional-surrender
branch
from
b9dcb29 to
e778c8c
Compare
|
@swift-ci please smoke test |
|
⛵️ |
jrose-apple
pushed a commit
to jrose-apple/swift
that referenced
this pull request
Jul 1, 2017
[Shepherd] Do stricter checking of -D command line arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases #6813 and updates a failing test.
Fixes SR-2404.