ClosureSpecializer: We don't need to insert releases for inlined thin_to_thick functions #10255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_to_thick functions rdar://32595213
|
@swiftix Can you review? |
|
@swift-ci Please test |
|
LGTM! |
|
Build failed |
|
@swift-ci Please test mac os x platform |
|
@swift-ci Please test os x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure we inline thin_to_thick closures into functions that may throw.
• Explanation: Enables inlining of non-capturing closures into throwing functions (like Collection map).
• Scope of Issue: MapReduceString regressed recently because of this. With this optimization we recover most of a 40% regression.
• Origination: N/A
• Risk: Low.
rdar://32595213