Upstream lib/Migrator to Open Source #10260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After both the syntactic and fix-it passes have run, perform a diff of the start and end states' texts and output the remap file. rdar://problem/30926019
- Don't include inserts in the offset calculation - Fix colon placement when printing JSON - Consolidate adjacent insert/removal pairs into a single replacement, as this is what the remap applier expects. rdar://problem/31872288
…. Resolves rdar://problem/31892850.
rdar://31897099
rdar://31897426
…en merged in from github.
Xcode has some interesting behavior w.r.t. standalone removal entries. In the previous migrator, there was an adjustment for that, so port that over. rdar://problem/31976029
Resolves rdar://problem/31977848.
… picked up by the differ Also add tests covering these API changes. Changes that the migrator doesn't currently support are commented out.
This was added in the AppKit overlay as a part of general AppKit API improvements for Swift 4. rdar://problem/32178777
rdar://problem/31070486
Add a requires line to the test as such. rdar://problem/32235754
The clang::RewriteBuffer can do weird things when seeing multiple replacements where the replacement text is one character longer or one character shorter than the range it is replacing. rdar://problem/32234525
This code is too clever to survive and is causing crashes in the migrator. It doesn't appear to be providing a noticeable performance benefit, so disable line-level diffing and just do a fine-grained diff throughout. rdar://problem/32281108
Build fix - the reference to Float80 is failing on iOS bots because the declaration is guarded by an #if. rdar://problem/32317183
…n to an overriding property.
Setting up an invocation adds -aarch64-use-tbi if the target is for AArch64. In the fix-it passes, we inherit the frontend options which already has it from the driver passing it down to the frontend. rdar://problem/32284152
Attempt to fix rdar://problem/32470725
…sent empty argument label instead of using "_". (#9988)
We already had this functionality in the FixitApplyDiagnosticConsumer, but we also need it in the AST passes because different entries in the API diff data may drive identical fix-its, namely a general type rename, which can occur anywhere a DeclRef appears, but also for function overrides' parameter type changes, which are context specific. rdar://problem/32431533
These protocol methods were hard-obsoleted in Swift 4. rdar://problem/32437759
…ow include moved static members. rdar://32466196
If a file is run through the migration workflow a second or third time, but fails to compile in its current state in Swift 4, it might be possible for the previous remap file to get picked up, resulting in the old changes getting applied twice or at the wrong offsets. At the start of the migration, proactively remove the remap file to prevent this. rdar://problem/32545844
The migrator pass that converts single-argument function input types doesn't handle the case when the function input has a label and is therefore a tuple. Expand it to handle that possibility. rdar://problem/32477319
|
@swift-ci Please smoke test |
|
Linux failure is sporadic. For OS X, looks like the SDKs aren't updated on the open source bots right now, so I'll xfail the test. |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
Ah, Mishal is updating things now, so I'll hold off and run the tests again once it's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of patches to upstream all lib/Migrator functionality to open source.