Reduce the code size of the standard library by about 5%-6% #10263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to reduce the stdlib code size This shaves off 3.2% of the stdlib’s code size.
This should reduce the code size of the stdlib by 1.5%.
…e size Move the error reporting slow-path into a separate function, which is not inlined or specialized. This reduced the stdlib code size by almost 1%.
|
@swift-ci please test |
|
@aschwaighofer Could you please review this PR? |
|
LGTM |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Nice! |
|
@swift-ci please test |
|
@swift-ci please test osx |
|
Build failed |
|
Build failed |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please test linux |
|
@swift-ci please test OS X |
|
@swift-ci please smoke test OS X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the code size of the standard library by about 5%-6% by adding annotations preventing inlining and/or generic specialization in a couple of places. These places were identified by means of the cmpcodesize utility.
• Explanation: Reduce the code size of the standard library dylib.
• Scope of Issue: Inlining and specialization of some generic functions were causing significant code increase without providing any performance improvements. This PR addresses this issue.
• Origination: N/A
• Risk: Very low. This patch is cherry-picked from the master, where these changes have been landed a week ago and have not caused any issues or performance regressions. The only effect of this PR is the reduced code size of the stdlib.
rdar://problem/32776747