[NFC] Refactor parameter counting #10271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepares the AST for future work to eliminate `getInput()` and perform function type argument matching in a less ad-hoc manner.
DougGregor
reviewed
Jun 15, 2017
| Identifier Label; | ||
|
|
||
| /// Whether the parameter has a default argument. Not valid for arguments. | ||
| bool HasDefaultArgument = false; |
There was a problem hiding this comment.
HasDefaultArgument doesn't belong in the type. I think you will need to use something other than CallArgParam for your storage.
| @@ -2295,7 +2323,8 @@ getSILFunctionLanguage(SILFunctionTypeRepresentation rep) { | |||
| /// be 'thin', indicating that a function value has no capture context and can be | |||
| /// represented at the binary level as a single function pointer. | |||
| class AnyFunctionType : public TypeBase { | |||
| const Type Input; | |||
| const ArrayRef<CallArgParam> Input; | |||
There was a problem hiding this comment.
I'd prefer to tail-allocate the parameters in the subclasses, so we don't pay for this extra pointer in such a common type.
| RecursiveTypeProperties properties, | ||
| const ExtInfo &Info) | ||
| : TypeBase(Kind, CanTypeContext, properties), | ||
| Input((CanTypeContext ?: &RawInput->getASTContext())->AllocateCopy(Input)), |
There was a problem hiding this comment.
Hmm... I'm confused why we're doing the CanTypeContext null check dance here. If we do the tail allocation thing, then don't need to do the AllocateCopy dance here... we just copy over the data we get.
|
I destroyed any hope of a reasonable merge here. Going to reopen this elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first test of the new function representation, use it to count parameters in CSGen.
Depends on #10264
Pre-rebase the relevant code is in
CSGen.cpp