Unqualified lookup cleanup #10277
Merged
Unqualified lookup cleanup #10277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to walk up the parent contexts here.
resolveGenericTypeParamType(), resolveTypeOfDecl() and resolveTypeOfContext() would all take the type of a declaration, and optionally map it into context. Replace them with a mapTypeIntoContext() that takes a type and either returns it verbatim or maps it into context.
When an unqualified reference is overloaded, we would walk the list of overload candidates and check if they are all member accesses. If they are, we would form an UnresolvedMemberRefExpr with the right base. Otherwise, we would form an UnresolvedDeclRefExpr. Now, consider forming an UnresolvedMemberRefExpr even if some of the members are types. This forces all nested type lookups to go through getTypeOfMemberReference(), not getTypeOfReference(). As a result, we no longer pass nested types to the resolveTypeInContext() function from expression checking. This will allow resolveTypeInContext() to take the base declaration on which the nested type was found as a parameter, instead of walking parent DeclContexts to try to guess what the right base was.
slavapestov
force-pushed
the
unqualified-lookup-cleanup
branch
from
b1e0503 to
61b7eff
Compare
… to check type witnesses Regression was introduced by ec60c88. I don't have a reduced test case, but this solves <rdar://problem/32668454>.
slavapestov
changed the title
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
The source compat suite failed because vapor UPASS'd -- which is good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.