Skip to content

Tweak test to make it fail to compile regardless of SE-0110. #10287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2017
Merged

Tweak test to make it fail to compile regardless of SE-0110. #10287

merged 1 commit into from
Jun 15, 2017

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Jun 15, 2017

No description provided.

@rudkx
Copy link
Contributor Author

rudkx commented Jun 15, 2017

@swift-ci Please smoke test

@rudkx rudkx requested a review from bitjammer June 15, 2017 19:10
bitjammer
bitjammer reviewed Jun 15, 2017
View reviewed changes
Copy link
Contributor

@bitjammer bitjammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this successfully compile?

@rudkx
Copy link
Contributor Author

rudkx commented Jun 15, 2017

never_compiles_safely_exits.swift calls that like this:

func bar() {
  foo(bar)
}

@bitjammer
Copy link
Contributor

Ah, right. Cool.

@rudkx rudkx merged commit 0a43288 into swiftlang:master Jun 15, 2017
@rudkx rudkx deleted the tweak-migrator-test branch June 15, 2017 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitjammer bitjammer bitjammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudkx @bitjammer