Skip to content

[4.0] [StdlibUnittest] Avoid serializing references to ObjC runtime APIs #10304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2017
Merged

[4.0] [StdlibUnittest] Avoid serializing references to ObjC runtime APIs #10304

merged 1 commit into from
Jun 16, 2017

Conversation

jrose-apple
Copy link
Contributor

@jrose-apple jrose-apple commented Jun 16, 2017 •
edited
Loading

  • Explanation: Avoid crashes when mixing 3.2 and 4.0 modes in the Swift test suite under certain build configurations.
  • Scope: Affects our private StdlibUnittest only.
  • Radar: (none)
  • Reviewed by: @DougGregor
  • Risk: None. We don't ship this library or include it in downloadable toolchains.
  • Testing: It fixed the issue on master.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

@swiftix or @moiseev, can you "review" this (i.e. confirm it will not affect end users)?

@DougGregor
Copy link
Member

LGTM. This won't have any effect on end users, but will help our testing run smoother

@ematejska ematejska merged commit bf823ee into swiftlang:swift-4.0-branch Jun 16, 2017
@jrose-apple jrose-apple deleted the 4.0-avoid-deserialization-failures-on-bots branch June 16, 2017 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrose-apple @DougGregor @ematejska @swift-ci