Skip to content

[Exclusivity] Switch static checking to use IndexTrie instead of Proj… #10305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

devincoughlin
Copy link
Contributor

…ectionPath

IndexTrie is a more light-weight representation and it works well in this case.
This requires recovering the represented sequence from an IndexTrieNode, so
also add a getParent() method.

…ectionPath

IndexTrie is a more light-weight representation and it works well in this case.
This requires recovering the represented sequence from an IndexTrieNode, so
also add a getParent() method.
@devincoughlin
Copy link
Contributor Author

\cc @atrick

@devincoughlin
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@devincoughlin
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 06b9ed7
Test requested by - @devincoughlin

@devincoughlin
Copy link
Contributor Author

@swift-ci please test and merge

@atrick
Copy link
Contributor

atrick commented Jun 16, 2017

👍

@najacque
Copy link
Contributor

Huh. something is wonky with the PR test. Taking a look.

@najacque
Copy link
Contributor

@swift-ci please test and merge

@najacque
Copy link
Contributor

@swift-ci Please clean test

1 similar comment
@najacque
Copy link
Contributor

@swift-ci Please clean test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 06b9ed7
Test requested by - @najacque

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 06b9ed7
Test requested by - @najacque

@najacque
Copy link
Contributor

Master is busticated. There's a PR going in in a few mins that should fix it, then I'll kick this off again.

@najacque
Copy link
Contributor

@swift-ci please test and merge
Ok, let's try this again, now that master is fixed.

@najacque
Copy link
Contributor

@swift-ci please test

@shahmishal
Copy link
Member

Comment has to be before the trigger :)
@swift-ci please test and merge

@najacque
Copy link
Contributor

jinx!

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 06b9ed7
Test requested by - @najacque

@najacque
Copy link
Contributor

We had more breakage on master. Should be fixed now... Let's try this again.
@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 06b9ed7
Test requested by - @najacque

@devincoughlin
Copy link
Contributor Author

Let's "trie" this again.
@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 650c057 into swiftlang:master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants