[Foundation] Correct NSRange equality typo and add unit tests for newly added NSRange behaviors #10316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly added NSRange behaviors
|
@swift-ci please test |
itaiferber
approved these changes
Jun 16, 2017
| @@ -22,17 +22,23 @@ extension NSRange : Hashable { | |||
| } | |||
|
|
|||
| public static func==(_ lhs: NSRange, _ rhs: NSRange) -> Bool { | |||
| return lhs.location == rhs.location && rhs.length == rhs.length | |||
| return lhs.location == rhs.location && lhs.length == rhs.length | |||
Catfish-Man
approved these changes
Jun 16, 2017
parkera
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of pr #10282
This fixes rdar://problem/32649690 as well as a few other minor cleanup issues discovered when testing. And most importantly adds unit tests for the new functionality of NSRange
Explanation:
NSRange equality had a typo that incorrectly compared the length. Furthermore there were a few cases where the debugDescription should be improved as well as the string initializer had some edge cases. This commit addresses those failures.
Scope:
This is just runtime behavior of NSRange
Radar (and possibly SR Issue):
rdar://problem/32649690
Risk:
These are newly introduced behaviors that have no current adoption other than the initial seeds.
Testing:
A number of new tests were added to validate the behavior of the new NSRange functionality