[code-completion] Add filter rules for description in addition filter-name #10329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benlangmuir
commented
Jun 16, 2017
benlangmuir
commented
- Explanation: This is an extension to our "filter-rules" API for code-completion, which allows the client of sourcekitd to create custom filters to hide/show various kinds of completions. The new rule is for filtering based on the description text of the completion.
- Scope: Only affects clients that adopt the new API.
- Radar: rdar://problem/28920034
- Risk: Low; only affects clients that adopt the new API.
- Testing: Regression tests added.
…-name The filter name isn't helpful if you want to make rules about specific overloads - e.g. only show the [Int] subscript on Array. rdar://problem/28920034
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.