Skip to content

[swift-4.0-branch] [overlay] Add unavailble x/y to CGRect to redirect to minX/minY #10339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2017
Merged

[swift-4.0-branch] [overlay] Add unavailble x/y to CGRect to redirect to minX/minY #10339

merged 1 commit into from
Jun 17, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jun 16, 2017 •
edited
Loading

  • Explanation: Improves user expirience with the API by providing a fixit for a commonly misused CGRect properties.
  • Scope of Issue: .x and .y properties are not available and .minX and .minY should be used instead.
  • Risk: minimal, purely additive change with no functionality
  • Reviewed By: Nate Begeman
  • Testing: Automated test suite
  • Directions for QA: N/A
  • Radar: rdar://problem/32574121

@moiseev
Copy link
Contributor Author

moiseev commented Jun 16, 2017

@swift-ci Please test

@moiseev moiseev changed the title [overlay] Add unavailble x/y to CGRect to redirect to minX/minY [swift-4.0-branch] [overlay] Add unavailble x/y to CGRect to redirect to minX/minY Jun 16, 2017
@moiseev
Copy link
Contributor Author

moiseev commented Jun 16, 2017

Similar to: #10120

@tkremenek tkremenek merged commit 6bb802b into swiftlang:swift-4.0-branch Jun 17, 2017
@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 2fdad59
Test requested by - @moiseev

@moiseev moiseev deleted the cgrect-xy-4 branch June 19, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moiseev @swift-ci @tkremenek