Fixes for #dsohandle default arguments [4.0] #10349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters Some default parameter expressions like #file, #line, #function etc are emitted into the caller directly by SILGen, instead of being emitted as a call to a generator function. In these cases, we don't need to emit the generator function at all.
…n_external This allows it to be referenced from inlinable functions. Fixes <rdar://problem/32597278>.
|
@jckarter Here is the second version that fixes the issue more comprehensively -- can you take a look? |
|
@swift-ci Please test |
slavapestov
changed the title
|
Build failed |
|
@swift-ci Please test |
|
@swift-ci please clean test |
jckarter
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: A user reported assertion failures while trying to define a default argument with a value of #dsohandle for an @inline(__always) function. While the latter is not a documented feature, we shouldn't crash.
Scope of the issue: Affects a narrow set of use-cases but it's a simple fix I think.
Risk: Low
Tested: New tests added
Reviewed by: @jckarter
Radar: rdar://problem/32597278