Fix layering violation I introduced by putting _EmptyBoxStorage into the stubs library #10373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the stubs library Should fix the linkage issue on linux
|
@swift-ci Please smoke test |
jrose-apple
reviewed
Jun 19, 2017
stdlib/public/runtime/HeapObject.cpp
Outdated
|
|
||
| swift::HeapLocalVariableMetadata _emptyBoxStorageMetadata; | ||
|
|
||
| /// The signleton empty box storage object. |
stdlib/public/runtime/HeapObject.cpp
Outdated
| swift::HeapLocalVariableMetadata _emptyBoxStorageMetadata; | ||
|
|
||
| /// The signleton empty box storage object. | ||
| struct _SwiftEmptyBoxStorage _EmptyBoxStorage = { |
There was a problem hiding this comment.
Does this need to be exported or not? If so, it should probably be SWIFT_RUNTIME_STDLIB_INTERFACE; if not, it should probably be in an anonymous namespace.
(Also, no need for the struct here.)
There was a problem hiding this comment.
No this does not need to be exported.
|
@swift-ci Please smoke test |
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
Jun 20, 2017
…the stubs library (swiftlang#10373) * Fix layering violation I introduced by putting _EmptyBoxStorage into the stubs library Should fix the linkage issue on linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the linkage issue on linux