Skip to content

[4.0] [ASTPrinter] Allow error type in printTransformedType #10379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2017
Merged

[4.0] [ASTPrinter] Allow error type in printTransformedType #10379

merged 1 commit into from
Jun 19, 2017

Conversation

benlangmuir
Copy link
Contributor

@benlangmuir benlangmuir commented Jun 19, 2017 •
edited
Loading

  • Explanation: Code-completion of protocol requirements that use associated types that aren't (yet) provided are currently showing as "<null>".
  • Scope: Affects code-completion of requirements using associated types that aren't provided yet.
  • Radar: rdar://problem/30451236
  • Risk: What is the (specific) risk to the release for taking this change?
  • Testing: Regression tests added.

@benlangmuir
[ASTPrinter] Allow error type in printTransformedType
fac8d52 
When printing an associated type that is not provided (e.g. during
code-completion of overrides), we want to print the type even if there
are errors.

rdar://problem/30451236
@benlangmuir
Copy link
Contributor Author

@swift-ci please test

@slavapestov
Copy link
Contributor

LGTM.

@benlangmuir benlangmuir merged commit 6eeffb2 into swiftlang:swift-4.0-branch Jun 19, 2017
@benlangmuir benlangmuir deleted the cc-complete-error-type-override-4 branch June 19, 2017 21:19
@nathawes nathawes mentioned this pull request Aug 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlangmuir @slavapestov