Improve reporting of @objc inference issues from the Swift runtime #10406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etails about the declaration of the method (that is missing the @objc annotation) and a suggested fix-it. This changes the ABI of RuntimeErrorDetails, so we're also bumping the version.
|
LLDB PR: apple/swift-lldb#215 |
DougGregor
reviewed
Jun 22, 2017
stdlib/public/runtime/SwiftObject.mm
Outdated
| .replacementText = "@objc " | ||
| }; | ||
| RuntimeErrorDetails::Note note = { | ||
| .description = "Method declaration; add '@objc' here", |
There was a problem hiding this comment.
I would prefer
add '@objc' to expose this Swift declaration to Objective-C
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Swift runtime issue reporting for @objc inference to include details about the declaration of the method (that is missing the @objc annotation) and a suggested fix-it. This changes the ABI of RuntimeErrorDetails, so we're also bumping the version.
An appropriate LLDB pull request will follow.