[ClangImporter] Don't pass API notes options when compiling bitcode. #10422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids a bogus "argument unused" warning, since bitcode compilation doesn't bother to set up much of a Clang AST context. (-embed-bitcode compiles in two steps: source -> bitcode, then bitcode -> object file. This is about the second step.) Patch by Bob Wilson, who's currently on vacation but wanted this to get in sooner rather than later. rdar://problem/31372950
|
@swift-ci Please smoke test |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 20, 2017
…wiftlang#10422) Avoids a bogus "argument unused" warning, since bitcode compilation doesn't bother to set up much of a Clang AST context. (-embed-bitcode compiles in two steps: source -> bitcode, then bitcode -> object file. This is about the second step.) Patch by Bob Wilson, who's currently on vacation but wanted this to get in sooner rather than later. rdar://problem/31372950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids a bogus "argument unused" warning, since bitcode compilation doesn't bother to set up much of a Clang AST context. (
-embed-bitcodecompiles in two steps: source -> bitcode, then bitcode -> object file. This is about the second step.)Patch by @bob-wilson, who's currently on vacation but wanted this to get in sooner rather than later.
rdar://problem/31372950