[4.0] Sema: Ensure the array type for variadic tuple shuffles is always set. #10428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We neglected to set it on one path (a scalar-to-tuple conversion path currently only taken by subscript applications). Change TupleShuffleExpr's constructor to take it as an argument so this mistake is harder to make in the future. Fixes SR-5264 | rdar://problem/32860988.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
@DougGregor Mind reviewing this for 4.0? |
jckarter
changed the title
|
Build failed |
|
@swift-ci Please test OS X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: We neglected to set up the type of the variadic argument array when invoking a variadic subscript with a single argument.
Scope: Source compatibility regression affecting vapor
Issue: SR-5264 | rdar://problem/32860988
Risk: Low, small bug fix.
Testing: Swift CI, compatibility test suite