AST: Tweak a concrete-nested-type-of-archetype hack slightly #10439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an archetype conforms to a protocol abstractly (ie, it is not class-constrained and we don't have any further information other than that it conforms), we can recover nested types, but we cannot recover the conformance of those nested types to protocols if those conformances are concrete (the nested type might be concrete, or it might be a class-constrained archetype). To work around this, we added a hack where if the conformance lookup in the SubstitutionMap fails, we fall back to the module. This is horrible and unprincipled, but has to remain in place until more infrastructure is plumbed through. Commit 620db5f made this workaround apply in fewer cases, so that we could still catch cases where the SubstitutionMap was constructed with missing conformances. Unfortunately this workaround didn't handle the case where the nested type was an archetype with a superclass constraint. This will all go away soon, but for now tweak the logic a bit, since I really want to keep the "narrow" workaround in place and not the general fallback, otherwise we run the risk of SubstitutionMap conformance lookup bitrotting completely. Fixes <https://bugs.swift.org/browse/SR-4088> and <rdar://problem/32773028>.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an archetype conforms to a protocol abstractly (ie, it is
not class-constrained and we don't have any further information
other than that it conforms), we can recover nested types,
but we cannot recover the conformance of those nested types
to protocols if those conformances are concrete (the nested
type might be concrete, or it might be a class-constrained
archetype).
To work around this, we added a hack where if the conformance
lookup in the SubstitutionMap fails, we fall back to the module.
This is horrible and unprincipled, but has to remain in place
until more infrastructure is plumbed through.
Commit 620db5f made this
workaround apply in fewer cases, so that we could still catch
cases where the SubstitutionMap was constructed with missing
conformances.
Unfortunately this workaround didn't handle the case where the
nested type was an archetype with a superclass constraint.
This will all go away soon, but for now tweak the logic a bit,
since I really want to keep the "narrow" workaround in place
and not the general fallback, otherwise we run the risk of
SubstitutionMap conformance lookup bitrotting completely.
Fixes https://bugs.swift.org/browse/SR-4088 and
rdar://problem/32773028.