Skip to content

[swift-4.0-branch][overlay] Adding missing files to Intents/CMakeLists.txt #10451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jun 21, 2017

rdar://problem/32901674

@moiseev
Copy link
Contributor Author

moiseev commented Jun 21, 2017

@swift-ci Please test macOS platform

@moiseev
Copy link
Contributor Author

moiseev commented Jun 21, 2017

@swift-ci Please test Linux platform

extension INSearchCallHistoryIntent {
@available(iOS 11.0, watchOS 4.0, *)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a behavior change, even if it wasn't working before. Do we really not want to support this entry point on pre-iOS-11 systems?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Or rather, do the Intents folks not want to support this etc etc.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, the patch originated from the Intents team. 🤷‍♂️

@moiseev moiseev changed the title [overlay] Adding missing files to Intents/CMakeLists.txt [swift-4.0-branch][overlay] Adding missing files to Intents/CMakeLists.txt Jun 22, 2017
@moiseev
Copy link
Contributor Author

moiseev commented Jun 22, 2017

@swift-ci Please test

@swiftlang swiftlang deleted a comment from swift-ci Jun 22, 2017
@swiftlang swiftlang deleted a comment from swift-ci Jun 23, 2017
@moiseev moiseev merged commit aa9e077 into swiftlang:swift-4.0-branch Jun 23, 2017
@moiseev moiseev deleted the intents-missing-files-4 branch June 23, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants