Prefix countRepresentedWords with underscore [NFC] #10481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per comments, `countRepresentedWords` is slated for eventual removal along with `_words(at:)`; it's not a part of SE-0104, so let's show users that it's not intended for public consumption.
|
/cc @moiseev |
@swift-ci please test source compatibility |
|
@CodaFi These integers were only introduced in 4.0, so there should be no 3.0 code that could use it. And hence no compatibility problems =) |
|
@xwu Thanks! |
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An incidental issue uncovered while reading through the code for other reasons:
Per comments,
countRepresentedWordsis slated for eventual removal along with_word(at:). It's not a part of SE-0104. Therefore, let's show users that it's not intended for public consumption.Interestingly, all current uses of the API in the Swift project itself are for implementing
_word(at:)or calling_word(at:).