[4.0] [ConstraintSolver] Use a flag to prevent solver from removing possible solutions #10522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e solutions In some situations e.g. while trying to shrink domains of the type variables before attempting search, use a flag to tell constraint system to retain all of the viable solutions otherwise solver could loose some of the information required to produce complete solution. Resolves: rdar://problem/32726044 (cherry picked from commit 6231f85)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: In some situations e.g. while trying to shrink domains of the type
variables before attempting search, use a flag to tell constraint
system to retain all of the viable solutions otherwise solver could
loose some of the information required to produce complete solution.
Scope of the issue: Type Checker changes to allow
shrinkto be more precise.Risk: Low.
Tested: New test cases added, Swift CI.
Reviewed by: Mark Lacey.
Resolves: rdar://problem/32726044
(cherry picked from commit 6231f85)