Skip to content

[4.0][index] Add missing parameter and return type references in subscript declarations #10537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nathawes
Copy link
Contributor

  • Explanation: The indexer wasn't covering subscript params or return types, resulting in a rename of any type references there failing and renames initiated on other occurrences of those types not updating them.
  • Scope of Issue: Affects rename of symbols used in subscript param/return types.
  • Radar: rdar://problem/32314185
  • Origination: The indexer was explicitly avoiding indexing subscript indices, though its unclear why from (the 2013 commit message doesn't mention a reason).
  • Risk: Low; This patch removes special case handling of subscripts.
  • Testing: Added regression tests for these cases

… declarations

Resolves rdar://problem/32314185.
@nathawes
Copy link
Contributor Author

@swift-ci Please test

@nathawes nathawes changed the title [index] Add missing parameter and return type references in subscript declarations [4.0][index] Add missing parameter and return type references in subscript declarations Jun 23, 2017
@nathawes nathawes merged commit b1911dd into swiftlang:swift-4.0-branch Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant