ARCCodeMotion: fix two problems in release hoisting: #10586
Merged
+126
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) PostOrderAnalysis is not invalidated after splitting critical edges. This let the data flow solver omit new inserted blocks. 2) Handle infinite loops in the CFG correctly. So that we don’t insert random release instructions into such CFG pathes. https://bugs.swift.org/browse/SR-5187 rdar://problem/32713742
|
@swift-ci Please test |
|
*) Explanation: The compiler can crash if there are infinite loops in the swift source code. *) Scope: Although this is not a common case, it can happen. For example if in an release build the assertFailure is replace by a no-op. *) Origin: https://bugs.swift.org/browse/SR-5187, rdar://problem/32713742 *) Risk: Low. It only affects control flow graphs with infinite loops |
|
Build failed |
|
@swift-ci Please test macos |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostOrderAnalysis is not invalidated after splitting critical edges. This let the data flow solver omit new inserted blocks.
Handle infinite loops in the CFG correctly. So that we don’t insert random release instructions into such CFG pathes.
https://bugs.swift.org/browse/SR-5187
rdar://problem/32713742