[4.0] [Clang importer] Infer @_downgrade_exhaustivity_check for new-to-2017 enum elements in Swift 3 #10599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enum elements in Swift 3. In Swift 3 mode, infer @_downgrade_exhaustivity_check for any enum elements that were introduced in the 2017 SDKs (macOS 10.13, iOS 11.0, tvOS 11.0, watchOS 4.0). This is a stop-gap until we get "open" enums, but serves an important source-compatibility use case. Fixes rdar://problem/32824207. (cherry picked from commit f855d2f)
(cherry picked from commit 8914ec6)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: In Swift 3 mode, downgrade the "switch is not exhaustive" error to a warning when the missing cases were introduced in the 2017 SDKs.
Scope: Fixes a source-compatibility problem with the newer SDKs for applications that are switching on enums provided by the system.
Radar: rdar://problem/32824207.
Risk: Low; we're inferring a new attribute in specific cases in the Clang importer, which only affects diagnostics.
Testing: Compiler regression tests.