[ClangImporter] Filter import-as-member decls by preferred submodule. #10612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coming up with this still-very-brittle test case was a pain. @swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
jrose-apple
commented
Jun 27, 2017
| @@ -0,0 +1,5 @@ | |||
| #import <Foundation.h> | |||
There was a problem hiding this comment.
Whoops, meant to remove this line.
That is, if a member is redeclarable, use the module of the definition if possible, and the canonical declaration otherwise. This is consistent with what we do when we actually import the declaration. Without this, we can end up dropping declarations. rdar://problem/32816381
jrose-apple
force-pushed
the
import-as-member-submodule-check
branch
from
132737e to
fc8a24a
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 27, 2017
…swiftlang#10612) That is, if a member is redeclarable, use the module of the definition if possible, and the canonical declaration otherwise. This is consistent with what we do when we actually import the declaration. Without this, we can end up dropping declarations. rdar://problem/32816381
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 27, 2017
…swiftlang#10612) That is, if a member is redeclarable, use the module of the definition if possible, and the canonical declaration otherwise. This is consistent with what we do when we actually import the declaration. Without this, we can end up dropping declarations. rdar://problem/32816381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, if a member is redeclarable, use the module of the definition if possible, and the canonical declaration otherwise. This is consistent with what we do when we actually import the declaration. Without this, we can end up dropping declarations.
rdar://problem/32816381