[4.0] [QoI] Improve contextual error diagnostics related to calls #10616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently some contextual errors are discovered too late which leads to diagnostics of unrelated problems like argument mismatches, these changes attempt to improve the situation and try to diagnose contextual errors related to calls before everything else. Resolves: SR-5045, rdar://problem/32934129 (cherry picked from commit 4e6677e)
|
@swift-ci please test |
|
@rudkx please review for 4.0 |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Currently some contextual errors are discovered too late
which leads to diagnostics of unrelated problems like argument
mismatches, these changes attempt to improve the situation
and try to diagnose contextual errors related to calls
before everything else.
Scope of the issue: diagnostic improvements for contextual errors related to calls.
Risk: Low.
Tested: New test cases added, Swift CI.
Reviewed by: Mark Lacey.
Resolves: SR-5045, rdar://problem/32934129