[4.0jun23] [Type checker] Always record used conformances in the source file. #10641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An early exit introduced in PR swiftlang#10292 meant that we would only record a protocol conformance as "used" in the first file in which we saw a reference to the conformance. Make sure we record the conformance as used in each source file that needs it. Fixes rdar://problem/32978891 and rdar://problem/32980176. (cherry picked from commit 8246367) (cherry picked from commit c12e784)
|
@swift-ci please test and merge |
…-source-file-4.0jun23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: An early exit introduced in PR #10292 meant that we would only record
a protocol conformance as "used" in the first file in which we saw a
reference to the conformance. Make sure we record the conformance as
used in each source file that needs it.
Scope: Ensures that we emit synthesized protocol conformances that are needed in each source file. No impact on source compatibility.
Radar: rdar://problem/32978891 and rdar://problem/32980176
Risk: Zero. We're emitting some witness tables/protocol conformances that were getting dropped earlier.
Testing: Compiler regression testing, building several projects that broke due to this bug.