[String] Grapheme fast paths for punctuation: 5-8x speedup. #10648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many strings use non-sub-300 punctuation characters (e.g. unicode hyphen, CJK quotes, etc). This can cause switching between fast and slow paths for grapheme breaking. Add in fast-paths for general punctuation characters and CJK punctuation and symbol characters. This results in about a 5-8x speedup for heavily (unicode) punctuated Latiny and CJKy workloads.
milseman
force-pushed
the
unicode_punk_shoe_a_shun
branch
from
056567b to
bd5189c
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@shahmishal Bots are having issues: |
|
@swift-ci please smoke test |
|
@swift-ci please benchmark |
|
Yup edit: I'll wait until after I get some testing / benchmarking results, don't want to invalidate the bots with a push. |
We had network outage. |
Build comment file:Build failed before running benchmark. |
|
@swift-ci please test |
|
@swift-ci please smoke benchmark |
|
Build failed |
|
Build failed |
Build comment file:Optimized (O)Regression (5)
Improvement (3)
No Changes (302)
Added (8)
Unoptimized (Onone)Regression (2)
Improvement (7)
No Changes (301)
Added (8)
Hardware Overview |
jrose-apple
reviewed
Jun 28, 2017
| // 0x2010-0x2029 | ||
| case 0x2010...0x2029: return true | ||
|
|
||
| // CJK punctuation characters, excluding extenders: |
There was a problem hiding this comment.
What do you mean by "extenders"?
There was a problem hiding this comment.
The characters (i.e. scalars) that have the "extend" property for the purposes of grapheme breaking. Such characters usually* don't have a grapheme break before them. E.g. 0x302A.
See:
http://unicode.org/reports/tr29/#GB9
http://www.unicode.org/Public/UCD/latest/ucd/auxiliary/GraphemeBreakProperty.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many strings use non-sub-300 punctuation characters (e.g. unicode
hyphen, CJK quotes, etc). This can cause switching between fast and
slow paths for grapheme breaking. Add in fast-paths for general
punctuation characters and CJK punctuation and symbol characters.
This results in about a 5-8x speedup for heavily (unicode) punctuated
Latiny and CJKy workloads.