[GSB] Distinguish archetype resolution kind for getNestedType(). #10661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PotentiallArchetype::getNestedType(Identifier...) was using ArchetypeResolutionKind::AlwaysPartial, even though only one client (the code that itself handles AlwaysPartial) needed it. Add an ArchetypeResolutionKind parameter to pass through, updating clients accordingly. Eliminates 5 effective uses of AlwaysPartial. Only two left!
It was failing to crash for the wrong reasons; this needs more work (and a proper reduction).
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PotentialArchetype::getNestedType(Identifier...)was usingArchetypeResolutionKind::AlwaysPartial, even though only one client(the code that itself handles
AlwaysPartial) needed it. Add anArchetypeResolutionKindparameter to pass through, updating clientsaccordingly.
Eliminates 5 effective uses of
AlwaysPartial. Only two left!Reinstate crasher from SR-4737 / rdar://problem/31905232. It was failing to crash for the wrong reasons; this needs more work (and a proper reduction).