Fix warnings in DispatchQueue.sync() implementation when using a comp… #10713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiseev
reviewed
Jun 29, 2017
test/stdlib/Dispatch.swift
Outdated
| @@ -40,6 +40,13 @@ DispatchAPI.test("DispatchGroup creation") { | |||
| expectNotNil(group) | |||
| } | |||
|
|
|||
| DispatchAPI.test("Dispatch sync return value") { | |||
| let value = 24; | |||
There was a problem hiding this comment.
Minor, but the rest of this file seems to be using 2 spaces for indentation.
|
The corresponding change for the overlay is at swiftlang/swift-corelibs-libdispatch#268 |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
…iler with SE-0176 support.
|
Fixed test file indent per Max's review comment. |
|
Thank you, that seems fine to me. |
|
@swift-ci Please test and merge |
das
approved these changes
Jul 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iler with SE-0176 support.
(Radar 32888663)