[Bridging PCH] Move dependency-on-bridging-PCH to -emit-bc JobAction itself. #10735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itself. (cherry picked from commit d4ff453)
|
@swift-ci please test |
akyrtzi
approved these changes
Jun 30, 2017
jrose-apple
approved these changes
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix a misplaced dependency edge in bridging PCH driver logic.
Scope: Causes a "missing PCH" error in certain cases when doing an
"Archive" build in Xcode on a target that includes embedded LLVM
bitcode. The root cause was a misplaced dependency edge in the swift
driver logic, which was benign in the first iteration of bridging PCH, but
which becomes a serious error when combined with recent changes to make
bridging PCH files persist between compilations.
Radar: 32984579
Risk: Low, the change only moves a dependency edge in the driver a step
earlier, making the driver graph strictly more-conservative in the order
it runs things.
Testing: A testcase was added to the existing testsuite which exhibits the
required dependency edge. Plus usual run of testsuite.