Guaranteed ownership transforming terminators #10759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some small control flow. NFC.
|
@swift-ci smoke test and merge |
|
Messed up. This is going to fail. 1 sec. |
|
Interesting. Turns out if you forget to end a borrow, the error is that you are leaking. I think I can improve that error. |
This is needed to ensure that SILGenPattern propagates values at +0 instead of +1. I also improved our handling of terminators in general when it comes to having "borrowed" arguments. The basic verification requirement is that the end_borrow_argument is treated as a use of the parent borrow. This ensures that the borrowed argument can not extend the lifetime of the borrowed value without the verifier triggering. rdar://31880847
…ter. rdar://31880847
gottesmm
force-pushed
the
guaranteed_ownership_transforming_terminators
branch
from
fe00037 to
69393d5
Compare
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR teaches the ownership-verifier how to handle guaranteed arguments with values provided by a switch_enum or a checked_cast_br.
The specific properties that the verifier checks is that the argument's ownership kind is the same as the ownership of the terminators argument. For the owned case, we verify the users of the argument separately from the users of the operand. But in the case of guaranteed parameters, we add the end_borrow_argument instruction of the guaranteed argument to the "must live" set of the terminator's operand. This means that the guaranteed value must live as long as the argument does implying that all uses of the guaranteed argument must be within that liveness region.