Large Types IRGen Pass: add support for transforming return of large types into indirect returns #10771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shajrawi
force-pushed
the
indirect_return
branch
2 times, most recently
from
47ae208 to
17d9bf3
Compare
…types into indirect returns
|
@swift-ci Please smoke test |
|
Why a new inout argument instead of just changing the result to be an out argument? |
|
Hmm that should work - I will look into modifying the implementation to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/28680453
This PR improves the new IRGen pass by adding support for result types.
Result types that are Large loadable types are replaced by empty tuples.
At the call site, we add a new stack allocation and pass said allocated space as a new
inoutargument to the apply site. After the call is executed this new argument will contain a pointer to the previously returned result.