[tests] More granular tests for faster builds #10778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
For comparison: the most recent successful build for the PR took 1 hr 33 min on macOS-33. |
|
/cc @shahmishal |
|
Build failed |
|
@swift-ci Please test |
Hmm... Something's not right. |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@swift-ci Please clean test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few validation tests that take a very long time to execute. Say, there are 2 tests that take 1000 seconds each, and the rest are single seconds. It is possible that a single executor will get both of those long tests, while all the other fast ones land on other executors. So the test time would be 2000 seconds, and roughly half of this time will be spent in just one thread.
This change splits the long running tests into (even) smaller pieces, thus halving the maximum duration of a single test file execution.