Skip to content

[QoI] Don't try to lookup members on incorrect type while diagnosing keypath components #10779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jul 6, 2017

While trying to diagnose problems related to keypath components
don't assume that type of the component is always correct, check
before trying to see if it's bridged type or has members.

Resolves SR-5370.
Resolves: rdar://problem/33135487

…keypath components

While trying to diagnose problems related to keypath components
don't assume that type of the component is always correct, check
before trying to see if it's bridged type or has members.

Resolves: rdar://problem/33135487
@xedin xedin requested a review from jckarter July 6, 2017 00:26
@xedin
Copy link
Contributor Author

xedin commented Jul 6, 2017

@swift-ci please smoke test

@xedin xedin requested a review from rudkx July 6, 2017 04:58
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Pavel!

@xedin xedin merged commit be204f2 into swiftlang:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants