[Exclusivity] Relax closure enforcement on separate stored properties #10789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test Linux |
Make the static enforcement of accesses in noescape closures stored-property
sensitive. This will relax the existing enforcement so that the following is
not diagnosed:
struct MyStruct {
var x = X()
var y = Y()
mutating
func foo() {
x.mutatesAndTakesClosure() {
_ = y.read() // no-warning
}
}
}
To do this, update the access summary analysis to summarize accesses to
subpaths of a capture.
rdar://problem/32987932
devincoughlin
force-pushed
the
exclusivity-interprocedural-separate-stored-structs-round2
branch
from
7557712 to
7d1cdca
Compare
devincoughlin
changed the title
devincoughlin
changed the title
devincoughlin
changed the title
|
@swift-ci Please test and merge |
devincoughlin
added a commit
to devincoughlin/swift
that referenced
this pull request
Jul 10, 2017
…swiftlang#10789) Make the static enforcement of accesses in noescape closures stored-property sensitive. This will relax the existing enforcement so that the following is not diagnosed: struct MyStruct { var x = X() var y = Y() mutating func foo() { x.mutatesAndTakesClosure() { _ = y.read() // no-warning } } } To do this, update the access summary analysis to summarize accesses to subpaths of a capture. rdar://problem/32987932
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the static enforcement of accesses in noescape closures stored-property
sensitive. This will relax the existing enforcement so that the following is
not diagnosed:
struct MyStruct {
var x = X()
var y = Y()
mutating
func foo() {
x.mutatesAndTakesClosure() {
_ = y.read() // no-warning
}
}
}
To do this, update the access summary analysis to summarize accesses to
subpaths of a capture.
rdar://problem/32987932