Skip to content

Remove ImportHintKind::Reference #10807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jul 7, 2017

The only place in the Clang Importer that needs to deal with anything
related to C++, and it doesn't actually do anything. Remove the
import hint and the last place where the importer creates InOutTypes
as well.

The only place in the Clang Importer that needs to deal with anything
related to C++, and it doesn't actually do anything.  Remove the
import hint and the last place where the importer creates InOutTypes
as well.
@CodaFi CodaFi requested a review from jrose-apple July 7, 2017 01:54
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 7, 2017

@swift-ci please test

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 7, 2017

@rjmccall The blame shows you were the last one to touch this codepath, but even then it was just shuffling some code around. Can you remember what this is for?

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want this some day, but we can deal with it then. LGTM!

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 7, 2017

@swift-ci please test source compatibility

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 7, 2017

Source compatibility failures are unrelated.

@CodaFi CodaFi merged commit fda424b into swiftlang:master Jul 7, 2017
@CodaFi CodaFi deleted the dereference branch July 7, 2017 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants