Skip to content

Sema: Coerce [keyPath:] index to rvalue. #10810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Jul 7, 2017

Fixes SR-5384 | rdar://problem/33160409.

Fixes SR-5384 | rdar://problem/33160409.
@jckarter
Copy link
Contributor Author

jckarter commented Jul 7, 2017

@swift-ci Please smoke test

@jckarter
Copy link
Contributor Author

jckarter commented Jul 7, 2017

@phausler Recognize this corelibs foundation build error?

Foundation/NSRange.swift:264:40: error: '_utf16Index' is unavailable
                location: r.lowerBound._utf16Index - target.startIndex._utf16Index,
                                       ^~~~~~~~~~~
Swift.String.Index:14:16: note: '_utf16Index' was obsoleted in Swift 4.0
    public var _utf16Index: Int { get }
               ^
Foundation/NSRange.swift:264:72: error: '_utf16Index' is unavailable
                location: r.lowerBound._utf16Index - target.startIndex._utf16Index,
                                                                       ^~~~~~~~~~~
Swift.String.Index:14:16: note: '_utf16Index' was obsoleted in Swift 4.0
    public var _utf16Index: Int { get }
               ^
Foundation/NSRange.swift:265:38: error: '_utf16Index' is unavailable
                length: r.upperBound._utf16Index - r.lowerBound._utf16Index
                                     ^~~~~~~~~~~
Swift.String.Index:14:16: note: '_utf16Index' was obsoleted in Swift 4.0
    public var _utf16Index: Int { get }
               ^
Foundation/NSRange.swift:265:65: error: '_utf16Index' is unavailable
                length: r.upperBound._utf16Index - r.lowerBound._utf16Index
                                                                ^~~~~~~~~~~
Swift.String.Index:14:16: note: '_utf16Index' was obsoleted in Swift 4.0
    public var _utf16Index: Int { get }
               ^

@phausler
Copy link
Contributor

phausler commented Jul 7, 2017

Cc @dabrahams this was part of your string index changes right?

@nkcsgexi
Copy link
Contributor

nkcsgexi commented Jul 7, 2017

#10812 is to revert this potential culprit.

@nkcsgexi
Copy link
Contributor

nkcsgexi commented Jul 7, 2017

@swift-ci Please smoke test

@jckarter jckarter merged commit 04453d1 into swiftlang:master Jul 7, 2017
@dabrahams
Copy link
Contributor

@phausler yes this was my doing; I failed to merge swiftlang/swift-corelibs-foundation#1096
so stuff broke, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants