Fix sys::Cache for ref-counted values which caused memory leaks in SourceKit #10822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benlangmuir
commented
Jul 7, 2017
benlangmuir
commented
- Explanation: Our libcache implementation of swift::sys::Cache was broken for ref-counted values (which are used by e.g. the SourceKit ASTManager). This was causing us to never release ASTs cached by SourceKit even when the underlying libcache purged itself under memory pressure.
- Scope: Affects memory usage under high system load on macOS.
- Radar: rdar://problem/21619189
- Testing: Unit tests added.
…urceKit Our libcache implementation of swift::sys::Cache was broken for ref-counted values (which are used by e.g. the SourceKit ASTManager). It would always `retain(value)` in `set(key, value)`, but under the hood libcache shares values, so we would only get one `release(value)` if the same value was used across multiple keys, or if the same value *and* key were set multiple times. This was causing us to never release ASTs cached by SourceKit even when the underlying libcache purged itself under memory pressure. rdar://problem/21619189
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.