[semantic-sil] Teach the verifier that an enum return value is a ValueOwnershipKind erasure point. #10833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eOwnershipKind erasure point. This means that a trivial enum case of a non-trivial enum can be returned @owned even though it is trivial. We already follow this pattern with bb arguments. rdar://31880847
|
@swift-ci smoke test and merge |
|
On another note, this on my machine actually gets stdlibCore to pass the verifier. I am hitting a separate issue verifying dispatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[semantic-sil] Teach the verifier that an enum return value is a ValueOwnershipKind erasure point.
This means that a trivial enum case of a non-trivial enum can be returned @owned
even though it is trivial. We already follow this pattern with bb arguments.
rdar://31880847