fix minor mistake #10839
Merged
fix minor mistake #10839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `flatMap` method. Parameter transform: A closure that takes the unwrapped value, right?
LuizZak
reviewed
Jul 10, 2017
stdlib/public/core/Optional.swift
Outdated
| /// | ||
| /// - Parameter transform: A closure that takes the unwrapped value | ||
| /// of the instance. | ||
| /// - Returns: The result of the given closure. If this instance is `nil`, | ||
| /// returns `nil`. | ||
| @_inlineable | ||
| public func flatMap<U>( | ||
| _ transform: (Wrapped) throws -> U? | ||
| _ transform: (Unwrapped) throws -> U? |
There was a problem hiding this comment.
Will this compile? I assume Wrapped is the type that comes from the generic parametrization of Optional<Wrapped>, i.e. it's not really a parameter name that can be changed.
There was a problem hiding this comment.
This change is also outside the scope of the documentation change and should be reverted.
There was a problem hiding this comment.
you're right. I ignored the Optional<Wrapped> and just look at the surface. and please modify the example's result 1764. and I will close this. I'm new to swift, thanks for feedback.
|
Good catch, thanks! ⛵️ |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
flatMapmethod. Parameter transform: A closure that takes the unwrapped value, right?and the example's result is 1764, not 1746.