Tighten up unavailable witness error and add a command-line option limiting typo correction #10846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Swift 4 Swift 3 allowed a requirement to be satisfied by an unavailable witness, which doesn't make sense. We've been warning about it in Swift 3 for a while; make it an error in Swift 4.
Typo correction can be particularly expensive, so introduce a command-line flag to limit the number of typo corrections we will perform per type-checker instance. Default this limit to 10. Addresses rdar://problem/28469270 to some extent.
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Type checker] Bump warning about unavailable witnesses to an error in Swift 4, and
Introduce a command-line option to limit the # of typo corrections.