Skip to content

String Index Interchange, etc. (Changes for SE-0180 => swift-4.0-branch) #10852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 11, 2017
Merged

String Index Interchange, etc. (Changes for SE-0180 => swift-4.0-branch) #10852

merged 15 commits into from
Jul 11, 2017

Conversation

dabrahams
Copy link
Contributor

No description provided.

@dabrahams dabrahams mentioned this pull request Jul 10, 2017
Merged
@dabrahams
Copy link
Contributor Author

Please test with the following pull request:
swiftlang/swift-corelibs-foundation#1105

@swift-ci Please test

@dabrahams
Copy link
Contributor Author

Please test with the following pull request:
swiftlang/swift-corelibs-foundation#1105

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - ccc41d8
Test requested by - @dabrahams

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ccc41d8
Test requested by - @dabrahams

Dave Abrahams and others added 15 commits July 10, 2017 14:38
[stdlib] Index interchange, part I
187ffb4
[stdlib] String index interchange, part II (UTF16)
5c593ef
[stdlib] String index interchange, part III (UTF8)
60019bb
@natecook1000
[stdlib] Minimal docs for the new string index
96cb4cb
[stdlib] Bring back some SPI that Foundation-on-linux uses.
092ba48
[stdlib] UTF8View Iterator and count specialization
cb5d0ec
[stdlib] Foundation SPI fixup
c902a0d
[stdlib] Fix a test: String.UTF8View has its own Iterator now
213f0e7
[stdlib] Small correction to UTF8 Iterator
f8d0984 
This works either way I suppose, but the code is clearer now.
[stdlib] UTF8View: count by iterating
75bfa0f 
The fancy code didn't turn out to be any faster.
[stdlib] Speed String.UTF8View.count even more
647069d
[stdlib] Rebuild String.Index for UTF8View
71f2a4b
[stdlib] Drop a couple bogus duplicate tests
ef17d09 
Only the last of each set of dups gets run anyway.  See
https://bugs.swift.org/browse/SR-5362
[stdlib] Extend String index conversion tests for interchange
4526a93 
test the new APIs as well as the legacy failing conversions.
[stdlib] Repair some doc comments
df68ef5 
Drive-by fix while cherry-picking.
@dabrahams dabrahams force-pushed the index-interchange-4 branch from ccc41d8 to df68ef5 Compare July 10, 2017 21:39
@dabrahams
Copy link
Contributor Author

Please test with the following pull request:
swiftlang/swift-corelibs-foundation#1105

@swift-ci Please test

@dabrahams
Copy link
Contributor Author

Please test with the following pull request:
swiftlang/swift-corelibs-foundation#1105

@swift-ci Please test source compatibility

@dabrahams dabrahams requested a review from milseman July 10, 2017 22:07
@dabrahams
Copy link
Contributor Author

Local benchmarks gave me this result:

Regression (22)
TEST OLD NEW DELTA SPEEDUP
MapReduceString 64 80 +25.0% 0.80x
DropWhileCountableRange 20 24 +20.0% 0.83x
PrefixAnySequence 4399 5099 +15.9% 0.86x
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 3967 4504 +13.5% 0.88x
SortStringsUnicode 5909 6655 +12.6% 0.89x
ObjectiveCBridgeFromNSSetAnyObjectForced 3305 3684 +11.5% 0.90x
StringEdits 87311 96978 +11.1% 0.90x
SortSortedStrings 717 789 +10.0% 0.91x
SevenBoom 1314 1444 +9.9% 0.91x
SortLargeExistentials 6624 7245 +9.4% 0.91x
StringFromLongWholeSubstring 8509 9287 +9.1% 0.92x
StringBuilderLong 789 850 +7.7% 0.93x
SortLettersInPlace 1001 1070 +6.9% 0.94x
ArrayAppendToFromGeneric 346 369 +6.6% 0.94x
Sim2DArray 229 244 +6.6% 0.94x
SortStrings 1408 1495 +6.2% 0.94x
ArrayPlusEqualThreeElements 1380 1463 +6.0% 0.94x
SetExclusiveOr_OfObjects 8229 8722 +6.0% 0.94x
ObjectiveCBridgeFromNSArrayAnyObjectToString 34764 36801 +5.9% 0.94x
SuffixAnySeqCRangeIter 4361 4614 +5.8% 0.95x
ArraySubscript 1277 1350 +5.7% 0.95x
SetExclusiveOr 2502 2638 +5.4% 0.95x
Improvement (28)
TEST OLD NEW DELTA SPEEDUP
SubstringFromLongString 83 9 -89.2% 9.22x
SubstringFromLongStringGeneric 149 54 -63.8% 2.76x
Integrate 483 199 -58.8% 2.43x
ArrayAppendAscii 17664 7727 -56.3% 2.29x
ReversedDictionary 74 54 -27.0% 1.37x (?)
ArrayAppendLatin1 31783 24485 -23.0% 1.30x
ArrayAppendUTF16 30273 23900 -21.1% 1.27x
NopDeinit 23671 18693 -21.0% 1.27x
DropLastArrayLazy 6 5 -16.7% 1.20x
CStringShortAscii 4839 4052 -16.3% 1.19x
Prims 751 647 -13.8% 1.16x
CStringLongAscii 4116 3609 -12.3% 1.14x
DropFirstArray 20 18 -10.0% 1.11x
ClassArrayGetter 10 9 -10.0% 1.11x (?)
StringWithCString 49437 44574 -9.8% 1.11x
ArrayOfPOD 141 129 -8.5% 1.09x (?)
ObjectiveCBridgeFromNSArrayAnyObjectForced 3857 3549 -8.0% 1.09x
Join 343 318 -7.3% 1.08x
CharacterLiteralsLarge 5453 5058 -7.2% 1.08x
PrefixWhileSequenceLazy 28 26 -7.1% 1.08x
CStringLongNonAscii 1766 1644 -6.9% 1.07x
DropFirstAnyCollection 51 48 -5.9% 1.06x
PrefixWhileArray 52 49 -5.8% 1.06x
MapReduceAnyCollection 248 234 -5.6% 1.06x (?)
Array2D 1637 1547 -5.5% 1.06x
PolymorphicCalls 19 18 -5.3% 1.06x
StringFromLongWholeSubstringGeneric 20 19 -5.0% 1.05x (?)
PrefixArrayLazy 20 19 -5.0% 1.05x (?)

@dabrahams dabrahams requested a review from moiseev July 10, 2017 23:47
@airspeedswift airspeedswift merged commit a578ee3 into swift-4.0-branch Jul 11, 2017
@moiseev moiseev deleted the index-interchange-4 branch July 12, 2017 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman Awaiting requested review from milseman

@moiseev moiseev Awaiting requested review from moiseev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dabrahams @swift-ci @airspeedswift @natecook1000