[ClangImporter] Structs lexically in an ObjC class are still top-level. #10874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not every declaration that's syntactically in an Objective-C container is a member of that container. Double-check the decl context before adding it. This is technically a breaking change in non-asserts builds, because the struct really could be found via member lookup. But that should be considered a bug, and I /suspect/ no one is relying on it. rdar://problem/32451417
|
@swift-ci Please test macOS |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test Linux |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jul 11, 2017
…l. (swiftlang#10874) Not every declaration that's syntactically in an Objective-C container is a member of that container. Double-check the decl context before adding it. This is technically a breaking change in non-asserts builds, because the struct really could be found via member lookup. But that should be considered a bug, and I /suspect/ no one is relying on it. rdar://problem/32451417
jrose-apple
added a commit
that referenced
this pull request
Jul 11, 2017
…l. (#10874) (#10878) Not every declaration that's syntactically in an Objective-C container is a member of that container. Double-check the decl context before adding it. This is technically a breaking change in non-asserts builds, because the struct really could be found via member lookup. But that should be considered a bug, and I /suspect/ no one is relying on it. rdar://problem/32451417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not every declaration that's syntactically in an Objective-C container is a member of that container. Double-check the decl context before adding it.
This is technically a breaking change in non-asserts builds, because the struct really could be found via member lookup. But that should be considered a bug, and I suspect no one is relying on it.
rdar://problem/32451417