[4.0] Allow resolved KeyPath and KeyPathApplication exprs to re-type-check. #10880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubscript components into getCalleeDeclAndArgs. Fixes SR-5189 | rdar://problem/32713662.
…onstructor. A preemptive strike against memory management bugs in the future. (cherry picked from commit 963c58c)
…ng failure diagnosis. Fixes SR-5034 | rdar://problem/32488872.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The compiler would silently fail during failure diagnosis when some expressions involving key path literals failed to type-check.
Scope: Malformed code using key paths would frequently crash the compiler instead of giving meaningful error messages.
Issue: rdar://problem/32488872 | SR-5034
Risk: Low, bug fix isolated to failure recovery on key paths. Should have no effect on correct code.
Testing: Swift CI, test cases from Jira
NB: This builds on the patch from #10863.